Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sageWithDoc: fix Sphinx warnings which break docgen #160220

Merged
merged 1 commit into from Feb 16, 2022

Conversation

collares
Copy link
Member

@collares collares commented Feb 15, 2022

Motivation for this change

Sphinx 4.4.0 (updated in #155976) introduced some new warnings in sphinx-doc/sphinx#9800, but they turned out to be too intrusive and will be disabled in 4.4.1 (sphinx-doc/sphinx#10126). For the time being, fix the warnings by importing a Trac patch.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@omasanori omasanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the patch upstream. This is a non-functional and harmless change. Thank you for your prompt work as usual!

@7c6f434c 7c6f434c merged commit e5fbe6a into NixOS:master Feb 16, 2022
@collares collares deleted the sage-sphinx-4.4 branch March 22, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants