Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

black: 21.12b0 -> 22.1.0 #157800

Merged
merged 1 commit into from Feb 15, 2022
Merged

black: 21.12b0 -> 22.1.0 #157800

merged 1 commit into from Feb 15, 2022

Conversation

aaronjheng
Copy link
Contributor

Motivation for this change

https://github.com/psf/black/releases/tag/22.1.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from autophagy and sveitser February 2, 2022 04:54
sveitser
sveitser suggested changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at the dependencies and I think we don't need attrs anymore. psf/black@31f4105

Apart from that LGTM, thanks!

@ofborg ofborg bot requested a review from sveitser February 3, 2022 08:50
@ofborg ofborg bot requested a review from sveitser February 4, 2022 01:43
sveitser
sveitser approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sveitser sveitser mentioned this pull request Feb 6, 2022
Closed
13 tasks
@sveitser sveitser mentioned this pull request Feb 13, 2022
Closed
13 tasks
@dotlambda

This comment was marked as spam.

Sign in to view
@ofborg ofborg bot requested a review from sveitser February 14, 2022 02:20
@dotlambda
Copy link
Member

Please target staging.

@aaronjheng
Copy link
Contributor Author

@dotlambda You mean staging branch, right?

@dotlambda
Copy link
Member

@dotlambda You mean staging branch, right?

Yes

@aaronjheng aaronjheng changed the base branch from master to staging February 15, 2022 01:47
@aaronjheng
Copy link
Contributor Author

@dotlambda Done.

@dotlambda dotlambda merged commit 273a460 into NixOS:staging Feb 15, 2022
@aaronjheng aaronjheng deleted the black branch February 16, 2022 07:11
@gador gador mentioned this pull request Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@autophagy autophagy Awaiting requested review from autophagy

@sveitser sveitser Awaiting requested review from sveitser

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aaronjheng @dotlambda @sveitser