Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discourse: 2.7.9 -> 2.8.0.beta8, update plugins #147277

Closed
wants to merge 1 commit into from
Closed

discourse: 2.7.9 -> 2.8.0.beta8, update plugins #147277

wants to merge 1 commit into from

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Nov 24, 2021

fixes #146308

Motivation for this change

new versions and #146308

Things done

Ran the updaters and partially fixed the patch for libv8-node. It build still fails currently:

$ nix-build -A discourseAllPlugins
these 2 derivations will be built:
  /nix/store/949c74rwvjgihyvwrhg7260hdl81lwcf-discourse-assets-2.8.0.beta8.drv
  /nix/store/bjdc5zly68dd300pzlaasv4n9zd64dsx-discourse-2.8.0.beta8.drv
building '/nix/store/949c74rwvjgihyvwrhg7260hdl81lwcf-discourse-assets-2.8.0.beta8.drv'...
unpacking sources
unpacking source archive /nix/store/x2qc7qb5c402qc0s83c79fp8ffjzl9v2-source
source root is source
patching sources
applying patch /nix/store/fwr2l8n5jfd9h1c7h5v30cc9plsm44ik-plugin_gem_api_version.patch
patching file lib/plugin_gem.rb
applying patch /nix/store/rrk1fql4369rc7pivmwi8d86fjkal4pb-auto_generated_path.patch
patching file lib/plugin/instance.rb
Hunk #1 succeeded at 447 (offset 44 lines).
configuring
no configure script, doing nothing
building
Waiting for Redis and PostgreSQL to be ready..
psql: error: could not connect to server: No such file or directory
        Is the server running locally and accepting
        connections on Unix domain socket "/build/.s.PGSQL.5432"?
2021-11-24 17:39:08.822 UTC [32] LOG:  starting PostgreSQL 13.4 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 10.3.0, 64-bit
2021-11-24 17:39:08.822 UTC [32] LOG:  listening on IPv4 address "127.0.0.1", port 5432
2021-11-24 17:39:08.823 UTC [32] LOG:  listening on Unix socket "/build/.s.PGSQL.5432"
2021-11-24 17:39:08.824 UTC [36] LOG:  database system was shut down at 2021-11-24 17:39:08 UTC
2021-11-24 17:39:08.825 UTC [32] LOG:  database system is ready to accept connections
CREATE ROLE
CREATE DATABASE
CREATE EXTENSION
CREATE EXTENSION
Failed to report error: can't modify frozen String: "<unknown>" 2 Deprecation notice: (ldap) message is no longer used because all logins are full screen. It should be removed from the auth_provider (removal in Discourse 2.9.0)
At /build/source/lib/plugin/instance.rb:740:in `public_send`
Failed to report error: can't modify frozen String: "<unknown>" 2 Creating scope :pending. Overwriting existing method DiscoursePostEvent::EventDate.pending.
2021-11-24 17:39:11.578 UTC [87] ERROR:  relation "user_actions" does not exist at character 454
2021-11-24 17:39:11.578 UTC [87] STATEMENT:  SELECT a.attname, format_type(a.atttypid, a.atttypmod),
               pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod,
               c.collname, col_description(a.attrelid, a.attnum) AS comment
          FROM pg_attribute a
          LEFT JOIN pg_attrdef d ON a.attrelid = d.adrelid AND a.attnum = d.adnum
          LEFT JOIN pg_type t ON a.atttypid = t.oid
          LEFT JOIN pg_collation c ON a.attcollation = c.oid AND a.attcollation <> t.typcollation
         WHERE a.attrelid = '"user_actions"'::regclass
           AND a.attnum > 0 AND NOT a.attisdropped
         ORDER BY a.attnum

Failed to report error: can't modify frozen String: "<unknown>" 2 Creating scope :open. Overwriting existing method Poll.open.
Warning: no type cast defined for type "name" with oid 19. Please cast this type explicitly to TEXT to be safe for future changes.


#
# Fatal error in ../../src/api/api.cc, line 5674
# Embedder-vs-V8 build configuration mismatch. On embedder side pointer compression is DISABLED while on V8 side it's ENABLED.
#
#
#
#FailureMessage Object: 0x7fffffff77b0
==== C stack trace ===============================

    /nix/store/pgbvbggx3cl0q7dw6l11n726wd183ky8-discourse-ruby-env-2.8.0.beta8/lib/ruby/gems/2.7.0/extensions/x86_64-linux/2.7.0/mini_racer-0.5.0/mini_racer_extension.so(v8::base::debug::StackTrace::StackTrace()+0x16) [0x7ffff2c2bef6]
    /nix/store/pgbvbggx3cl0q7dw6l11n726wd183ky8-discourse-ruby-env-2.8.0.beta8/lib/ruby/gems/2.7.0/extensions/x86_64-linux/2.7.0/mini_racer-0.5.0/mini_racer_extension.so(+0x62cd6c) [0x7ffff1d1ed6c]
    /nix/store/pgbvbggx3cl0q7dw6l11n726wd183ky8-discourse-ruby-env-2.8.0.beta8/lib/ruby/gems/2.7.0/extensions/x86_64-linux/2.7.0/mini_racer-0.5.0/mini_racer_extension.so(V8_Fatal(char const*, int, char const*, ...)+0x173) [0x7ffff2c22e13]
    /nix/store/pgbvbggx3cl0q7dw6l11n726wd183ky8-discourse-ruby-env-2.8.0.beta8/lib/ruby/gems/2.7.0/extensions/x86_64-linux/2.7.0/mini_racer-0.5.0/mini_racer_extension.so(v8::V8::Initialize(int)+0x43) [0x7ffff1d2d443]
    /nix/store/pgbvbggx3cl0q7dw6l11n726wd183ky8-discourse-ruby-env-2.8.0.beta8/lib/ruby/gems/2.7.0/extensions/x86_64-linux/2.7.0/mini_racer-0.5.0/mini_racer_extension.so(+0x629d0e) [0x7ffff1d1bd0e]
    /nix/store/pgbvbggx3cl0q7dw6l11n726wd183ky8-discourse-ruby-env-2.8.0.beta8/lib/ruby/gems/2.7.0/extensions/x86_64-linux/2.7.0/mini_racer-0.5.0/mini_racer_extension.so(+0x62c570) [0x7ffff1d1e570]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe442) [0x7ffff7e8e442]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_call0+0xbf) [0x7ffff7e977df]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_call_kw+0x68) [0x7ffff7e97bd8]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_funcallv_kw+0x11e) [0x7ffff7e9d7de]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x11bc0c) [0x7ffff7dabc0c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe442) [0x7ffff7e8e442]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_yield+0xcd) [0x7ffff7e9fe6d]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_ensure+0xcc) [0x7ffff7d4049c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe523) [0x7ffff7e8e523]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_yield+0xcd) [0x7ffff7e9fe6d]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_ensure+0xcc) [0x7ffff7d4049c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe523) [0x7ffff7e8e523]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x20f54e) [0x7ffff7e9f54e]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x2061f7) [0x7ffff7e961f7]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe523) [0x7ffff7e8e523]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x20fc98) [0x7ffff7e9fc98]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f80c4) [0x7ffff7e880c4]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_catch_obj+0x2a) [0x7ffff7e881ba]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe523) [0x7ffff7e8e523]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_yield+0x75) [0x7ffff7e9fe15]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_ary_each+0x3c) [0x7ffff7cc9e6c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe523) [0x7ffff7e8e523]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_yield+0x75) [0x7ffff7e9fe15]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_ary_each+0x3c) [0x7ffff7cc9e6c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe523) [0x7ffff7e8e523]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_yield+0x75) [0x7ffff7e9fe15]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_ary_each+0x3c) [0x7ffff7cc9e6c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe523) [0x7ffff7e8e523]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x2043de) [0x7ffff7e943de]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x2047e3) [0x7ffff7e947e3]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe442) [0x7ffff7e8e442]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_yield+0x75) [0x7ffff7e9fe15]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_ensure+0xcc) [0x7ffff7d4049c]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe523) [0x7ffff7e8e523]
    /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
2021-11-24 17:39:15.743 UTC [98] LOG:  unexpected EOF on client connection with an open transaction
/nix/store/mq9pycra4p4i0gl79gxwzw603dx49n72-stdenv-linux/setup: line 127:    73 Aborted                 (core dumped) bundle exec rake db:migrate > /dev/null
error: builder for '/nix/store/949c74rwvjgihyvwrhg7260hdl81lwcf-discourse-assets-2.8.0.beta8.drv' failed with exit code 134;
       last 10 log lines:
       >     /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
       >     /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe442) [0x7ffff7e8e442]
       >     /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
       >     /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_yield+0x75) [0x7ffff7e9fe15]
       >     /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_ensure+0xcc) [0x7ffff7d4049c]
       >     /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1f39c2) [0x7ffff7e839c2]
       >     /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(+0x1fe523) [0x7ffff7e8e523]
       >     /nix/store/22hgrp938c7sfj1s4klhigddix2sqc12-ruby-2.7.4/lib/libruby-2.7.4.so.2.7(rb_vm_exec+0x9c) [0x7ffff7e93b2c]
       > 2021-11-24 17:39:15.743 UTC [98] LOG:  unexpected EOF on client connection with an open transaction
       > /nix/store/mq9pycra4p4i0gl79gxwzw603dx49n72-stdenv-linux/setup: line 127:    73 Aborted                 (core dumped) bundle exec rake db:migrate > /dev/null
       For full logs, run 'nix log /nix/store/949c74rwvjgihyvwrhg7260hdl81lwcf-discourse-assets-2.8.0.beta8.drv'.
error: 1 dependencies of derivation '/nix/store/bjdc5zly68dd300pzlaasv4n9zd64dsx-discourse-2.8.0.beta8.drv' failed to build
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ryantm ryantm force-pushed the dev/ryantm/discourse-update-beta8 branch from 6b80ef3 to 3042bd2 Compare November 24, 2021 17:41
@ofborg ofborg bot requested a review from talyz November 24, 2021 17:53
@ryantm
Copy link
Member Author

ryantm commented Nov 24, 2021

Looks like this may be relevant to why there are problems with COMPRESS_POINTERS rubyjs/mini_racer#210 (comment)

@talyz
Copy link
Contributor

talyz commented Nov 26, 2021

I looked into this and it turned out to be a fair bit of work updating to 2.8.0.beta8, so I've opened a separate PR for it with my proposed changes: #147506.

@ryantm ryantm closed this Nov 26, 2021
@ryantm ryantm deleted the dev/ryantm/discourse-update-beta8 branch November 26, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we package the Discourse Beta branch?
2 participants
@ryantm @talyz