python3Packages.blspy: unbreak #144230
Merged
python3Packages.blspy: unbreak #144230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbjubjub2494
force-pushed
the
fix/blspy
branch
from
e72d7d1
to
6eb1c7d
Compare
jonringer
reviewed
Nov 2, 2021
|
|
||
| # https://github.com/Chia-Network/bls-signatures/issues/286 | ||
| (fetchpatch { | ||
| url = "https://github.com/Chia-Network/bls-signatures/commit/797241e9dae1c164c862cbdb38c865d4b124a601.patch"; |
There was a problem hiding this comment.
do you mind making this into a PR then taking from the PR. This is only working because of all refs on the upstream repo
There was a problem hiding this comment.
There is a PR. If I understand you correctly, I'm not sure this would be better since the PR head is mutable. (and quite likely to change)
There was a problem hiding this comment.
I guess I'm suggesting that the PR ref should be in there as well
Suggested change
| url = "https://github.com/Chia-Network/bls-signatures/commit/797241e9dae1c164c862cbdb38c865d4b124a601.patch"; | |
| url = "https://github.com/Chia-Network/bls-signatures/pull/287/commits/797241e9dae1c164c862cbdb38c865d4b124a601.patch"; |
bbjubjub2494
force-pushed
the
fix/blspy
branch
2 times, most recently
from
7fdc177
to
f48d869
Compare
bbjubjub2494
force-pushed
the
fix/blspy
branch
from
f48d869
to
a956e7b
Compare
jonringer
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 144230 run on x86_64-linux 1
7 packages built:
- chia
- python38Packages.blspy
- python38Packages.clvm
- python38Packages.clvm-tools
- python39Packages.blspy
- python39Packages.clvm
- python39Packages.clvm-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#144209
Chia-Network/bls-signatures#286
Things done
Submit patch upstream
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)