black: 21.7b0 -> 21.8b0 #136792
Merged
black: 21.7b0 -> 21.8b0 #136792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
bump-black
branch
2 times, most recently
from
4306b94
to
62bec7d
Compare
sveitser
suggested changes
Sep 6, 2021
| @@ -10,6 +10,7 @@ | |||
| , mypy-extensions | |||
| , pathspec | |||
| , parameterized | |||
| , platformdirs | |||
There was a problem hiding this comment.
Can the appdirs dependency be removed? psf/black#2375
sveitser
reviewed
Sep 6, 2021
|
|
||
| disabled = pythonOlder "3.6"; | ||
|
|
||
| src = fetchPypi { | ||
| inherit pname version; | ||
| sha256 = "06d27adq6v6p8wspi0wwqz2pnq34p5jhnqvijbin54yyj5j3qdy8"; | ||
| sha256 = "sha256-VwYI0oqjrxeSuYxKM326xjZ4d7R7EriKtCCVz8GmJ8I="; |
There was a problem hiding this comment.
hash = ... is less redundant and more common
There was a problem hiding this comment.
We should stick to sha256 for now. As long as there is no decision made about this (#112388) and support present in the tools for auto-conversion (e.g., nix-update).
There was a problem hiding this comment.
Ok. Thanks for the explanation and for introducing me to nix-update 😄
sveitser
approved these changes
Sep 7, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bumped black and pathspec (due to a new requirement from black)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)