Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fastapi: fix build #122457

Merged
merged 2 commits into from May 11, 2021
Merged

python3Packages.fastapi: fix build #122457

merged 2 commits into from May 11, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

tiangolo/fastapi#2335 was merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from AluisioASG May 10, 2021 14:38
@ofborg ofborg bot requested a review from wd15 May 10, 2021 14:47
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 10, 2021 •
edited

Result of nixpkgs-review pr 122457 at b6e530a run on aarch64-linux 1

5 packages built successfully:
  • dyndnsc
  • python38Packages.fastapi
  • python38Packages.json-logging
  • python39Packages.fastapi
  • python39Packages.json-logging
1 suggestion:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/python-modules/fastapi/default.nix:32:5:

       |
32 |     (fetchpatch {
   |     ^

Result of nixpkgs-review pr 122457 at b6e530a run on x86_64-linux 1

5 packages built successfully:
  • dyndnsc
  • python38Packages.fastapi
  • python38Packages.json-logging
  • python39Packages.fastapi
  • python39Packages.json-logging
1 suggestion:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/python-modules/fastapi/default.nix:32:5:

       |
32 |     (fetchpatch {
   |     ^

@mweinelt
Copy link
Member

mweinelt commented May 10, 2021 •
edited

This will be available in FastAPI 0.65.0, released in a couple of hours.

Let's give the author a few hours here.

Also there is https://github.com/tiangolo/fastapi/releases/tag/0.64.0 (3 days ago), so even if we would go with the patch an update would be appropriate.

@mweinelt
Copy link
Member

https://github.com/tiangolo/fastapi/releases/tag/0.65.0

And here we are.

dotlambda
dotlambda commented May 10, 2021
View reviewed changes
pkgs/development/python-modules/json-logging/default.nix Outdated
disabledTests = [
"quart" # Quart is not packaged for Nixpkgs
] ++ lib.optionals (pythonAtLeast "3.9") [
"test_api_example" # network access
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really strange.

Copy link
Member Author

@dotlambda dotlambda May 10, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did urllib3 somehow change in Python 3.9 in a way such that local networking doesn't work in the sandbox anymore?

urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7ffff50a5f70>: Failed to establish a new connection: [Errno 111] Connection refused

cc @FRidh @jonringer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, it works now. Though the test looks a little flaky:
https://github.com/bobbui/json-logging-python/blob/1e887ca1dc949893e1757d29dc8a1d75fccc8dd1/tests/smoketests/test_run_smoketest.py#L42-L55

AluisioASG
AluisioASG suggested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@AluisioASG AluisioASG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, save for the leftover pythonAtLeast.

pkgs/development/python-modules/json-logging/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from AluisioASG May 11, 2021 17:36
@dotlambda dotlambda merged commit 1e14061 into NixOS:master May 11, 2021
@dotlambda dotlambda deleted the fastapi-fix branch May 11, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costrouc costrouc costrouc approved these changes

@AluisioASG AluisioASG AluisioASG approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@wd15 wd15 Awaiting requested review from wd15

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @r-rmcgibbo @mweinelt @costrouc @AluisioASG