Merge pull request meshery#2679 from aneeshnema/aneeshnema/mesherygh-…

…2678-pattern-api [meshery] return 404 when `api/experimental/patternfile/{id}` fetched with invalid id
Nikhil-Ladha · Apr 8, 2021 · 0f9a8e9 · 0f9a8e9
2 parents 6e0090e + 5a02fb4
commit 0f9a8e9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/handlers/extensions.go b/handlers/extensions.go
@@ -9,7 +9,7 @@ import (
 )
 
 var (
-	extendedEndpoints = make(map[string]*models.Router, 0)
+	extendedEndpoints = make(map[string]*models.Router)
 )
 
 func (h *Handler) ExtensionsEndpointHandler(w http.ResponseWriter, req *http.Request, prefObj *models.Preference, user *models.User, provider models.Provider) {

diff --git a/handlers/meshery_pattern_handler.go b/handlers/meshery_pattern_handler.go
@@ -122,7 +122,7 @@ func (h *Handler) SavePatternFile(
 
 	token, err := provider.GetProviderToken(r)
 	if err != nil {
-		http.Error(rw, fmt.Sprintf("failed to get user token"), http.StatusInternalServerError)
+		http.Error(rw, "failed to get user token", http.StatusInternalServerError)
 		return
 	}
 
@@ -188,7 +188,7 @@ func (h *Handler) GetMesheryPatternHandler(
 
 	resp, err := provider.GetMesheryPattern(r, patternID)
 	if err != nil {
-		http.Error(rw, fmt.Sprintf("failed to delete the pattern: %s", err), http.StatusInternalServerError)
+		http.Error(rw, fmt.Sprintf("failed to get the pattern: %s", err), http.StatusNotFound)
 		return
 	}
 

diff --git a/handlers/performance_profiles_handler.go b/handlers/performance_profiles_handler.go
@@ -31,7 +31,7 @@ func (h *Handler) SavePerformanceProfileHandler(
 
 	token, err := provider.GetProviderToken(r)
 	if err != nil {
-		http.Error(rw, fmt.Sprintf("failed to get user token"), http.StatusInternalServerError)
+		http.Error(rw, "failed to get user token", http.StatusInternalServerError)
 		return
 	}
 

diff --git a/handlers/schedule_handlers.go b/handlers/schedule_handlers.go
@@ -30,7 +30,7 @@ func (h *Handler) SaveScheduleHandler(
 
 	token, err := provider.GetProviderToken(r)
 	if err != nil {
-		http.Error(rw, fmt.Sprintf("failed to get user token"), http.StatusInternalServerError)
+		http.Error(rw, "failed to get user token", http.StatusInternalServerError)
 		return
 	}