feat(scan): implement scan functionality #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 0305650 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 99.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 97.9% (1.0% change). View more on Code Climate. |
derevnjuk
requested changes
Apr 21, 2022
There was a problem hiding this comment.
There are multiple bugs, please address them first, then I will proceed with the review.
In addition, pay attention to these comments as well:
- rename the
requestsfolder tocommands(we don't have such an entity) - remove the useless
enumsfolder (the folder structure should reflect the domain) - for each bug that I mention you should write a dedicated test case
RomanReznichenko
force-pushed
the
feat/scan
branch
from
ed0a5e6
to
93b3a9c
Compare
|
@RomanReznichenko please resolve codeclimate issues first |
derevnjuk
requested changes
Apr 26, 2022
There was a problem hiding this comment.
There are still multiple issues and bugs:
- The file is not satisfied HAR spec 1.2, e.g.
postDatais expected to be an object, cookies are empty, etc - Wrong query params serialization
- Wrong default body serialization in the
HarEntryBuilder - No error handling in the
Scans - Scan stops even while getting 502 error
- etc
@RomanReznichenko leave everything as is, I will fix them soon
derevnjuk
force-pushed
the
feat/scan
branch
4 times, most recently
from
6d14f6d
to
b13452f
Compare
derevnjuk
force-pushed
the
feat/scan
branch
3 times, most recently
from
c36ac30
to
5eedcdc
Compare
pmstss
reviewed
Apr 29, 2022
pmstss
previously approved these changes
Apr 29, 2022
pmstss
previously approved these changes
Apr 29, 2022
pmstss
previously approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42