Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade docusaurus #326

Merged
merged 2 commits into from Aug 5, 2022
Merged

Downgrade docusaurus #326

merged 2 commits into from Aug 5, 2022

Conversation

joshklop
Copy link
Contributor

@joshklop joshklop commented Aug 5, 2022

Version 2.0.1 breaks the github actions deploy. Based on the issue
below, docusaurus was working on 2.0.0-rc.1. This commit downgrades
docusuarus to the latter version.

See: facebook/docusaurus#7744

Types of changes

What types of changes does your code introduce?

  • Documentation Update
  • Build related changes

Testing

Note: right now we can only test github actions manually on our own machines. To test this PR, run the commands below:

cd docs
yarn install
yarn start

Version 2.0.1 breaks the github actions deploy. Based on the issue
below, docusaurus was working on 2.0.0-rc.1. This commit downgrades
docusuarus to the latter version.

See: facebook/docusaurus#7744
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #326 (f3449c0) into main (5961cc2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #326   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines         6783      6783           
=========================================
  Hits          6783      6783           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@tshakalekholoane tshakalekholoane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joshklop joshklop merged commit 99d8a62 into main Aug 5, 2022
@joshklop joshklop deleted the josh/downgrade-docusaurus branch August 5, 2022 19:22
IronGauntlets pushed a commit that referenced this pull request Aug 18, 2022
Version 2.0.1 breaks the github actions deploy. Based on the issue
below, docusaurus was working on 2.0.0-rc.1. This commit downgrades
docusuarus to the latter version.

See: facebook/docusaurus#7744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants