Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate IpcTagKey entries that are not in spec #885

Merged
merged 1 commit into from
May 21, 2021
Merged

deprecate IpcTagKey entries that are not in spec #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions spectator-ext-ipc/src/main/java/com/netflix/spectator/ipc/IpcLogEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,15 +641,11 @@ private Id createCallId(String name) {
putTag(tags, getAttemptFinal());

// Optional for client
putTag(tags, IpcTagKey.serverRegion.key(), serverRegion);
putTag(tags, IpcTagKey.serverZone.key(), serverZone);
putTag(tags, IpcTagKey.serverApp.key(), serverApp);
putTag(tags, IpcTagKey.serverCluster.key(), serverCluster);
putTag(tags, IpcTagKey.serverAsg.key(), serverAsg);
} else {
// Optional for server
putTag(tags, IpcTagKey.clientRegion.key(), clientRegion);
putTag(tags, IpcTagKey.clientZone.key(), clientZone);
putTag(tags, IpcTagKey.clientApp.key(), clientApp);
putTag(tags, IpcTagKey.clientCluster.key(), clientCluster);
putTag(tags, IpcTagKey.clientAsg.key(), clientAsg);
Expand Down
24 changes: 24 additions & 0 deletions spectator-ext-ipc/src/main/java/com/netflix/spectator/ipc/IpcTagKey.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,20 @@ public enum IpcTagKey {

/**
* Region where the client is located.
*
* @deprecated Not included in the spec. Common IPC tags should bias towards consistency
* across integrations and only use tags that are part of the spec.
*/
@Deprecated
clientRegion("ipc.client.region"),

/**
* Availability zone where the client is located.
*
* @deprecated Not included in the spec. Common IPC tags should bias towards consistency
* across integrations and only use tags that are part of the spec.
*/
@Deprecated
clientZone("ipc.client.zone"),

/**
Expand All @@ -130,12 +138,20 @@ public enum IpcTagKey {

/**
* Region where the server is located.
*
* @deprecated Not included in the spec. Common IPC tags should bias towards consistency
* across integrations and only use tags that are part of the spec.
*/
@Deprecated
serverRegion("ipc.server.region"),

/**
* Availability zone where the server is located.
*
* @deprecated Not included in the spec. Common IPC tags should bias towards consistency
* across integrations and only use tags that are part of the spec.
*/
@Deprecated
serverZone("ipc.server.zone"),

/**
Expand All @@ -156,12 +172,20 @@ public enum IpcTagKey {
/**
* Instance id for the server. <b>Do not use this unless you know it will not
* cause a metrics explosion. If there is any doubt, then do not enable it.</b>
*
* @deprecated Not included in the spec. Common IPC tags should bias towards consistency
* across integrations and only use tags that are part of the spec.
*/
@Deprecated
serverNode("ipc.server.node"),

/**
* The port number connected to on the server.
*
* @deprecated Not included in the spec. Common IPC tags should bias towards consistency
* across integrations and only use tags that are part of the spec.
*/
@Deprecated
serverPort("ipc.server.port"),

/**
Expand Down