Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZGC generational memory managers #1007

Merged
merged 2 commits into from Nov 18, 2022
Merged

Conversation

DanielThomas
Copy link
Member

Add ZGC generational memory manager labels.

genshen uses the same memory managers, but different pools and will go into a hybrid collection when necessary, so other than checking pool size changes, I'm not sure we can do anything there:

https://github.com/openjdk/shenandoah/blob/998f68b26b8d2a5178a30a6c5b596194961e3821/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp#L2928-L2935

@brharrington brharrington added this to the 1.4.1 milestone Nov 18, 2022
@brharrington
Copy link
Contributor

With generational ZGC is there still just a single pool name of ZHeap? We had to do some hacks to make allocation/promotion rate tracking work with the non-generational collectors (#847). Would that logic need to be revisited?

Similarly for generational Shenandoah is the only pool name Shenandoah?

@brharrington
Copy link
Contributor

It looks like it is Shenandoah Young Gen and Shenandoah Old Gen (code). So the old gen should be fine, but we'll probably need a check for Young Gen, right now it looks for Eden Space:

https://github.com/Netflix/spectator/blob/main/spectator-ext-gc/src/main/java/com/netflix/spectator/gc/HelperFunctions.java#L72

@DanielThomas
Copy link
Member Author

Made it a contains check.

@brharrington brharrington merged commit 10dc725 into main Nov 18, 2022
@brharrington brharrington deleted the dannyt/genzgc-known-collectors branch November 18, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants