Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with generational ZGC #1006

Merged
merged 1 commit into from Nov 18, 2022
Merged

Compatibility with generational ZGC #1006

merged 1 commit into from Nov 18, 2022

Conversation

DanielThomas
Copy link
Member

Non-generational Shenandoah and ZGC have two memory managers, one concurrent, one stop-the-world, named <gc> Cycles and <gc> Pauses:

However generational ZGC splits these into major/minor cycles/pauses:

Looks like there's no change required for genshen so far, they're using the same memory managers:

Allocation Stall is also not a special case, and just another concurrent cycle trigger. It does indicate a allocation stall occurred, but it's not a pause and doesn't tell you how long threads were paused for:

Found while testing genzgc early access builds:

Screenshot 2022-11-18 at 1 12 14 pm

Copy link
Contributor

@brharrington brharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, the only issue is it would alter behavior for some pre jdk17 versions with ZGC, but the data for those was sketchy anyway and those versions are now EOL.

@brharrington brharrington added this to the 1.4.1 milestone Nov 18, 2022
@brharrington brharrington merged commit 669c362 into main Nov 18, 2022
@brharrington brharrington deleted the dannyt/genzgc branch November 18, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants