Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret Backend Support for Azure Key Vault #1839

Merged
merged 1 commit into from
May 17, 2024

Conversation

iamsgarg-ob
Copy link
Contributor

@iamsgarg-ob iamsgarg-ob commented May 16, 2024

What is the change in this PR?

How is this tested?

  • Tested against Azure Key Vault

@savingoyal savingoyal requested a review from saikonen May 16, 2024 17:53
@iamsgarg-ob iamsgarg-ob force-pushed the az-gcp-secret-mgrs branch 5 times, most recently from 4473094 to 8239769 Compare May 16, 2024 21:22
@iamsgarg-ob iamsgarg-ob changed the title Secret Backend Support for Azure Key Vault and GCP Secret Manager Secret Backend Support for Azure Key Vault May 16, 2024
oavdeev
oavdeev previously approved these changes May 16, 2024
* Integration with Azure Key Vault

* adding support for options

* changing to bas64decode

* adding encoding support for different types of encodings supported in Azure

* fixes for encoding

* removing binary option from azure secret manager integration
Copy link
Collaborator

@oavdeev oavdeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@oavdeev oavdeev merged commit df8f685 into Netflix:master May 17, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants