Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves all calls to .all() within the */service.py files #4703

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

metroid-samus
Copy link
Contributor

This PR moves all session queries with all.() calls to */service.py files for consistency.

@metroid-samus metroid-samus added the bug Something isn't working label May 9, 2024
@metroid-samus metroid-samus self-assigned this May 9, 2024
@wssheldon
Copy link
Contributor

Nice! I think another good addition here would be to fix all the return types. That way, if you try to call .all() on one of these service functions you will get a type error w/ pyright.

list[Whatever] | None in most cases, I believe.

metroid-samus and others added 3 commits May 8, 2024 22:25
… additional .all() calls to */service.py files.
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
@metroid-samus metroid-samus marked this pull request as ready for review May 9, 2024 05:36
metroid-samus and others added 11 commits May 13, 2024 15:14
…pping (#4729)

* [Escalate] - Do not override user selected inc type with case type mapping

* Update src/dispatch/case/flows.py

Co-authored-by: Avery <averyl@netflix.com>

---------

Co-authored-by: Avery <averyl@netflix.com>
Bumps [faker](https://github.com/joke2k/faker) from 25.1.0 to 25.2.0.
- [Release notes](https://github.com/joke2k/faker/releases)
- [Changelog](https://github.com/joke2k/faker/blob/master/CHANGELOG.md)
- [Commits](joke2k/faker@v25.1.0...v25.2.0)

---
updated-dependencies:
- dependency-name: faker
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* bugfix: Reporter can be None in resources flows

* Add variable init for all_participants
@metroid-samus metroid-samus force-pushed the bugfix/fix-queries-with-suffix-all branch from d3b602f to af47b3a Compare May 16, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants