Support default parameters for DgsData methods #1403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Kotlin default parameter values for DgsData methods.
This is a follow up to PR #1302, where we added support for Kotlin default parameters when mapping input arguments; with this PR we now also support default parameters for the DgsData methods themselves.
Example:
If the schema does not require
input
and the query did not supply it, previously this would fail, even though thefetcher
method is written in a way to handle the missing input. This PR updates theDataFetcherInvoker
to call Kotlin methods reflectively using callBy which allows supporting default parameters by omitting values in the passed in Map when the parameter is optional.