Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Refactor Metrics #1280

Merged
merged 13 commits into from Oct 27, 2022
Merged

[Bugfix] Refactor Metrics #1280

merged 13 commits into from Oct 27, 2022

Commits on Oct 14, 2022

  1. Added "DgsException" for easier error handling 

    * Removed explicit empty query check so instrumentation can catch InvalidSyntax
* Mapped ValidationError and SyntaxError to BAD_REQUEST for micrometer
* Re-introduced micrometer to the example project
    @antholeole @berngp
    antholeole authored and berngp committed Oct 14, 2022
    Copy the full SHA
    b352287 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. added tests for DgsException

    @antholeole
    antholeole committed Oct 19, 2022
    Copy the full SHA
    e193956 View commit details
    Browse the repository at this point in the history

  2. added DGS execution result + tests

    @antholeole
    antholeole committed Oct 19, 2022
    Copy the full SHA
    33934a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. teach HttpHandlers about dgsExecutionResult

    @antholeole
    antholeole committed Oct 20, 2022
    Copy the full SHA
    1b99812 View commit details
    Browse the repository at this point in the history

  2. empty http request now returns 400

    @antholeole
    antholeole committed Oct 20, 2022
    Copy the full SHA
    a7beb8f View commit details
    Browse the repository at this point in the history

  3. updated instrumentation examples

    @antholeole
    antholeole committed Oct 20, 2022
    Copy the full SHA
    3b1bf4a View commit details
    Browse the repository at this point in the history

  4. added regression test for extension on response

    @antholeole
    antholeole committed Oct 20, 2022
    Copy the full SHA
    15e5139 View commit details
    Browse the repository at this point in the history

  5. fixed expected status code in empty query test

    @antholeole
    antholeole committed Oct 20, 2022
    Copy the full SHA
    0d72c99 View commit details
    Browse the repository at this point in the history

  6. added backwards compat for old method of adding headers

    @antholeole
    antholeole committed Oct 20, 2022
    Copy the full SHA
    8580ecd View commit details
    Browse the repository at this point in the history

  7. ran formatter

    @antholeole
    antholeole committed Oct 20, 2022
    Copy the full SHA
    18e73f5 View commit details
    Browse the repository at this point in the history

  8. fixed test expecting 200 when should be 400

    @antholeole
    antholeole committed Oct 20, 2022
    Copy the full SHA
    046c132 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into Netflix#1058-2

    @antholeole
    antholeole committed Oct 20, 2022
    Copy the full SHA
    d3fbddb View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Merge branch 'master' into Netflix#1058-2

    @antholeole
    antholeole committed Oct 26, 2022
    Copy the full SHA
    ed64a04 View commit details
    Browse the repository at this point in the history