Commits on Apr 22, 2022

1. Simplify DgsSSESubscriptionHandler by returning Flux …

   DgsSSESubscriptionHandler was rolling its own Subscriber implementation in order
   to adapt the Publisher returned by the GraphQL query to the SseEmitter; however,
   Spring itself will handle this when the content type is "text/event-stream" and
   we simply return a reactive type, such as Flux. Doing so greatly simplifies the
   code in the controller, and allows for future enhancements such as propagating
   context to the publisher.
   
   Another change is that any error condition occurring before the GraphQL query is
   executed successfully (e.g., a Publisher is returned) will result in a non-SSE response;
   that is, the status code of the response will be non-200, and the error message
   will no longer be written as a single server-sent event.
   
   Finally, the way errors are written has been fixed. Previously the entire stack trace
   was accidentally written to the event, now only the exception message is propagated.

   

   kilink committed Apr 22, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for d9d115d
   • Browse repository at this point

   Copy the full SHA

   d9d115d View commit details

   Browse the repository at this point in the history