[Bugfix] Refactor Metrics #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed explicit empty query check so instrumentation can catch InvalidSyntax * Mapped ValidationError and SyntaxError to BAD_REQUEST for micrometer * Re-introduced micrometer to the example project
antholeole
force-pushed
the
#1058-2
branch
5 times, most recently
from
a4ea394
to
6666853
Compare
|
@antholeole looks good to me, could you squash changes and rebase from master. Thanks for the PR and thanks again for introducing the |
berngp
approved these changes
Oct 26, 2022
|
@berngp rebased, instead of squashing my branch can you click "Squash and merge" when merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
first
Pull Request type
Changes in this PR
DgsExecutionResult. This makes it easy for developers to change the http status code, as well as add headers to the response should they wish do that (see the example)extensionswas being left on the response (bug: "extensions" exposed in valid graphQL request #1278)This now does not break adding headers through the extension method due to this change. Let me know if this is necessary or not, considering it was added less than a week ago and probably does not have wide adoption yet (not sure about internally).
In general, again, I'd recommend reviewing commit by commit - the initial commit (b352287) was updated by @/berngp so I'm assuming it passed review - all the other commits are my changes and are hopefully descriptive .
lmk thoughts.