Skip to content

Commit

Permalink
Merge pull request #690 from Netflix/fix-webclient-dependency
Browse files Browse the repository at this point in the history
Update compile only dependency on webclient to implementation.
  • Loading branch information
srinivasankavitha committed Oct 12, 2021
2 parents 9fd200f + cfe300b commit 464b88e
Show file tree
Hide file tree
Showing 24 changed files with 198 additions and 120 deletions.
5 changes: 0 additions & 5 deletions dependencies.lock
Expand Up @@ -195,11 +195,6 @@
"locked": "5.2.13.RELEASE"
}
},
"ktlint": {
"com.pinterest:ktlint": {
"locked": "0.40.0"
}
},
"nebulaRecommenderBom": {
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
Expand Down
2 changes: 1 addition & 1 deletion graphql-dgs-client/build.gradle.kts
Expand Up @@ -20,7 +20,7 @@ dependencies {
api("com.fasterxml.jackson.core:jackson-annotations")
api(project(":graphql-dgs-subscription-types"))

compileOnly("org.springframework:spring-webflux")
implementation("org.springframework:spring-webflux")

implementation("org.springframework:spring-web")
implementation("com.fasterxml.jackson.module:jackson-module-kotlin")
Expand Down
38 changes: 33 additions & 5 deletions graphql-dgs-client/dependencies.lock
Expand Up @@ -32,12 +32,18 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-kotlin": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-parameter-names": {
"locked": "2.12.3"
},
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
},
Expand Down Expand Up @@ -257,11 +263,6 @@
"locked": "5.2.13.RELEASE"
}
},
"ktlint": {
"com.pinterest:ktlint": {
"locked": "0.40.0"
}
},
"nebulaRecommenderBom": {
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
Expand Down Expand Up @@ -289,12 +290,18 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-kotlin": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-parameter-names": {
"locked": "2.12.3"
},
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
},
Expand Down Expand Up @@ -342,6 +349,9 @@
},
"org.springframework:spring-web": {
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webflux": {
"locked": "5.2.13.RELEASE"
}
},
"testAnnotationProcessor": {
Expand Down Expand Up @@ -371,12 +381,18 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-kotlin": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-parameter-names": {
"locked": "2.12.3"
},
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
},
Expand Down Expand Up @@ -500,6 +516,9 @@
},
"org.springframework:spring-web": {
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webflux": {
"locked": "5.2.13.RELEASE"
}
},
"testRuntimeClasspath": {
Expand All @@ -515,6 +534,9 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8": {
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs"
Expand All @@ -529,6 +551,9 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-parameter-names": {
"locked": "2.12.3"
},
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
},
Expand Down Expand Up @@ -729,6 +754,9 @@
],
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webflux": {
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webmvc": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-spring-webmvc-autoconfigure",
Expand Down
31 changes: 26 additions & 5 deletions graphql-dgs-example-java-webflux/dependencies.lock
Expand Up @@ -344,11 +344,6 @@
"locked": "5.2.13.RELEASE"
}
},
"ktlint": {
"com.pinterest:ktlint": {
"locked": "0.40.0"
}
},
"nebulaRecommenderBom": {
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
Expand Down Expand Up @@ -389,6 +384,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs",
Expand All @@ -406,6 +407,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-parameter-names": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
},
Expand Down Expand Up @@ -627,6 +634,7 @@
},
"org.springframework:spring-webflux": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client",
"com.netflix.graphql.dgs:graphql-dgs-reactive",
"com.netflix.graphql.dgs:graphql-dgs-spring-webflux-autoconfigure"
],
Expand Down Expand Up @@ -831,6 +839,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs",
Expand All @@ -848,6 +862,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-parameter-names": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
},
Expand Down Expand Up @@ -1075,6 +1095,7 @@
},
"org.springframework:spring-webflux": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client",
"com.netflix.graphql.dgs:graphql-dgs-reactive",
"com.netflix.graphql.dgs:graphql-dgs-spring-webflux-autoconfigure"
],
Expand Down
41 changes: 36 additions & 5 deletions graphql-dgs-example-java/dependencies.lock
Expand Up @@ -350,11 +350,6 @@
"locked": "5.2.13.RELEASE"
}
},
"ktlint": {
"com.pinterest:ktlint": {
"locked": "0.40.0"
}
},
"nebulaRecommenderBom": {
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
Expand Down Expand Up @@ -395,6 +390,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs",
Expand All @@ -411,6 +412,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-parameter-names": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
},
Expand Down Expand Up @@ -656,6 +663,12 @@
],
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webflux": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webmvc": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-spring-webmvc-autoconfigure"
Expand Down Expand Up @@ -880,6 +893,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs",
Expand All @@ -896,6 +915,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-parameter-names": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
},
Expand Down Expand Up @@ -1154,6 +1179,12 @@
],
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webflux": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webmvc": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-spring-webmvc-autoconfigure"
Expand Down
5 changes: 0 additions & 5 deletions graphql-dgs-example-shared/dependencies.lock
Expand Up @@ -292,11 +292,6 @@
"locked": "5.2.13.RELEASE"
}
},
"ktlint": {
"com.pinterest:ktlint": {
"locked": "0.40.0"
}
},
"nebulaRecommenderBom": {
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
Expand Down
23 changes: 18 additions & 5 deletions graphql-dgs-extended-scalars/dependencies.lock
Expand Up @@ -263,11 +263,6 @@
"locked": "5.2.13.RELEASE"
}
},
"ktlint": {
"com.pinterest:ktlint": {
"locked": "0.40.0"
}
},
"nebulaRecommenderBom": {
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
Expand Down Expand Up @@ -597,6 +592,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs",
Expand All @@ -612,6 +613,12 @@
],
"locked": "2.12.3"
},
"com.fasterxml.jackson.module:jackson-module-parameter-names": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "2.12.3"
},
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
},
Expand Down Expand Up @@ -819,6 +826,12 @@
],
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webflux": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-client"
],
"locked": "5.2.13.RELEASE"
},
"org.springframework:spring-webmvc": {
"firstLevelTransitive": [
"com.netflix.graphql.dgs:graphql-dgs-spring-webmvc-autoconfigure"
Expand Down
5 changes: 0 additions & 5 deletions graphql-dgs-mocking/dependencies.lock
Expand Up @@ -227,11 +227,6 @@
"locked": "5.2.13.RELEASE"
}
},
"ktlint": {
"com.pinterest:ktlint": {
"locked": "0.40.0"
}
},
"nebulaRecommenderBom": {
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
Expand Down
5 changes: 0 additions & 5 deletions graphql-dgs-pagination/dependencies.lock
Expand Up @@ -260,11 +260,6 @@
"locked": "5.2.13.RELEASE"
}
},
"ktlint": {
"com.pinterest:ktlint": {
"locked": "0.40.0"
}
},
"nebulaRecommenderBom": {
"com.fasterxml.jackson:jackson-bom": {
"locked": "2.12.3"
Expand Down

0 comments on commit 464b88e

Please sign in to comment.