Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MongoDb): Update errors and doc typo #421

Merged
merged 4 commits into from
Apr 10, 2024
Merged

fix(MongoDb): Update errors and doc typo #421

merged 4 commits into from
Apr 10, 2024

Conversation

youngmn
Copy link
Collaborator

@youngmn youngmn commented Apr 2, 2024

Description

  • Fix mongodb_image_products docs typo
  • Change the setting condition of arbiter_product_code : Make it configurable even if it is SINGLE_REPLICA_SET
  • Fix resource update errors

@youngmn youngmn requested a review from wonchulee as a code owner April 2, 2024 04:48
wonchulee
wonchulee reviewed Apr 2, 2024
View reviewed changes
internal/service/mongodb/mongodb.go Outdated Show resolved Hide resolved
internal/service/mongodb/mongodb.go Outdated Show resolved Hide resolved
internal/common/convert_types.go Outdated Show resolved Hide resolved
@wonchulee wonchulee changed the title fix(MongoDb): Fix update errors and doc typo fix(MongoDb): Update errors and doc typo Apr 10, 2024
wonchulee
wonchulee approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wonchulee wonchulee merged commit c18318d into main Apr 10, 2024
4 checks passed
@wonchulee wonchulee deleted the fix/mongodb branch April 10, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonchulee wonchulee wonchulee approved these changes

Assignees
No one assigned
Labels
bug documentation FRAMEWORK VPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@youngmn @wonchulee