Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hadoop): Update Hadoop resource and datasource #420

Merged
merged 5 commits into from
Apr 22, 2024
Merged

refactor(hadoop): Update Hadoop resource and datasource #420

merged 5 commits into from
Apr 22, 2024

Conversation

youngmn
Copy link
Collaborator

@youngmn youngmn commented Mar 26, 2024

Related

#390

Description

  • Update Resource : ncloud_hadoop
  • Update Data-Source : ncloud_hadoop
  • Change
    • LOG format
    • ERROR format
    • Refacoring Schema : naming, validation, type, bug fix
    • Update DOCS
    • Updae EXAMPLE

AccTest results

=== RUN   TestAccResourceNcloudHadoop_vpc_update
--- PASS: TestAccResourceNcloudHadoop_vpc_update (4848.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ncloud/internal/service/hadoop	4849.519s

@youngmn youngmn requested a review from wonchulee as a code owner March 26, 2024 01:14
wonchulee
wonchulee reviewed Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM 👍

docs/resources/hadoop.md Outdated Show resolved Hide resolved
docs/resources/hadoop.md Outdated Show resolved Hide resolved
docs/resources/hadoop.md Outdated Show resolved Hide resolved
docs/resources/hadoop.md Outdated Show resolved Hide resolved
internal/service/hadoop/hadoop.go Outdated Show resolved Hide resolved
internal/service/hadoop/hadoop.go Outdated Show resolved Hide resolved
wonchulee
wonchulee approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wonchulee wonchulee merged commit b96ef7c into main Apr 22, 2024
4 checks passed
@wonchulee wonchulee deleted the refact/hadoop_rsc branch April 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonchulee wonchulee wonchulee approved these changes

Assignees
No one assigned
Labels
documentation enhancement FRAMEWORK VPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@youngmn @wonchulee