provide more info when SBCF are different #771
Conversation
| @@ -157,8 +158,10 @@ public static void diff(final SeekableByteChannelFactory sbcf1, final SeekableBy | |||
| InputStream is1 = Channels.newInputStream(sbc1); | |||
| InputStream is2 = Channels.newInputStream(sbc2)) { | |||
| if (!IOUtils.contentEquals(is1, is2)) { | |||
| differences.add(String.format("%s not equal. 1.cs=%s 2.cs=%s", | |||
| identifier, sbc1.size(), sbc2.size())); | |||
| differences.add(String.format("%s not equal. 1.is=%s 2.is=%s", | |||
There was a problem hiding this comment.
We definitely don't want to spit out a string representation of the entire payload; that could be well over a GB for each object being compared.
There was a problem hiding this comment.
That makes sense, I hadn't considered that.
There was a problem hiding this comment.
Would it make sense to have it display a string representation of the first x characters? Where x is set to 64 for ease of debugging
There was a problem hiding this comment.
We could consider making that an option, but it would only be helpful if 1) the payload is text-like and decodes well using UTF_8 2) the difference occurs within the first few bytes.
| @@ -121,7 +122,8 @@ public static void diff(final List<IBaseDataObject> ibdoList1, final List<IBaseD | |||
| final int ibdoList2Size = (ibdoList2 == null) ? 0 : ibdoList2.size(); | |||
|
|
|||
| if (ibdoList1Size != ibdoList2Size) { | |||
| differences.add(String.format("%s%s: 1.s=%s 2.s=%s", identifier, ARE_NOT_EQUAL, ibdoList1Size, ibdoList2Size)); | |||
| differences.add(String.format("%s%s%sIBaseDataObject List Size 1: %s%sIBaseDataObject List Size 2: %s", | |||
| identifier, ARE_NOT_EQUAL, StringUtils.LF, ibdoList1Size, StringUtils.LF, ibdoList2Size)); | |||
There was a problem hiding this comment.
If we insert line breaks, it will break parsing of aggregated messages.
|
Line breaks and payload string removed from log messaging. Returned to original formatting with slightly adjusted wording for improved clarity. Before: After: |
When two
SeekableByteChannelFactoryobjects are found to not be the same, thedifferencesstring is currently appended with"<data parameter name> not equal. 1.cs=<byte channel 1 size> 2.cs=<byte channel 2 size>".This doesn't account for channels of the same size with different data. Finding these differences currently means stepping through the program with the debugger to manually convert each channel's input stream back into a string. Appending the data directly from each object makes this issue much easier to debug.
differenceswas also removed as the error message forassertNullinRegressionTestUtilbecause it already prints when the assert fails.