New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Built out ability to validate meta field names from xml files against filters using ExtractionTest #203
base: main
Are you sure you want to change the base?
Built out ability to validate meta field names from xml files against filters using ExtractionTest #203
Conversation
Updated the validation of the paramaters against the passed in filters. The filters have to be passed through the answer .xml. An example of this is included within TestValidateFieldExtractionTest.xml, but I will describe it here as well. Two things must be included in the .xml to indicate what filters and meta field names you want checked:
|
* @param key the current meta key name to validate against LogFilter | ||
* @param tname the current test name | ||
*/ | ||
protected void validateFieldInFilter(String key, String tname) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonar recommends breaking this method up to reduce complexity. Parts can possible be abstracted out into helper methods.
Not a blocker but something to be aware of.
…ed log lines within ExtractionTest
5d1c065
to
bcbb4ce
Compare
This is in reference to NationalSecurityAgency/burrito-grande#968.
This change to ExtractionTest allows for xml meta fields to be compared to filters to validate that meta names exist within filters.
Instruction updated below.
#203 (comment)