Skip to content
This repository has been archived by the owner on Jul 7, 2022. It is now read-only.

Update Java-WebSockets to 1.5.1 #89

Merged
merged 3 commits into from Sep 6, 2021
Merged

Conversation

nikoTM
Copy link
Contributor

@nikoTM nikoTM commented Oct 27, 2020

Breaking changes:

EDIT:

Updated jar taken from here Java-WebSocket-1.5.1-with-dependencies.jar

@nikoTM
Copy link
Contributor Author

nikoTM commented Oct 28, 2020

@NathanaelA

Since Java-WebSockets seems to be using SLF4J for logging, this build will log the following errors:

System.err: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
System.err: SLF4J: Defaulting to no-operation (NOP) logger implementation
System.err: SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Can be solved by adding a gradle dependency with

implementation group: 'org.slf4j', name: 'slf4j-simple', version: '1.7.25'

But I thought it should be left to the plugin user to decide wether or not they want that dependency.

@NathanaelA NathanaelA merged commit bd3f896 into NathanaelA:master Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants