Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit GitHub Actions CI to write Packages, needed for php-build caching #1290

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

osma
Copy link
Member

@osma osma commented Mar 14, 2022

Reasons for creating this PR

I'm trying to get tests on GitHub Actions CI working again. This PR fixes part of the problem - the permission issue preventing php-build from caching PHP containers as Packages.

Link to relevant issue(s), if any

Description of the changes in this PR

Allow Actions to write Packages according to GitHub documentation

Known problems or uncertainties in this PR

Tests are still broken on PHP 7.x (see #1288) but at least the PHP containers get built and stored as Packages and tests on PHP 8.0 are passing.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 2.15 milestone Mar 14, 2022
@osma osma self-assigned this Mar 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osma osma merged commit ffc1d62 into master Mar 14, 2022
@osma osma added this to Issue/PR closed in Sprint Backlog II/2022 Mar 17, 2022
@osma osma moved this from Issue/PR closed to Done (verified in dev.finto.fi and documented in wiki and RN, Milestone metadata) in Sprint Backlog II/2022 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Sprint Backlog II/2022
  
Done (verified in dev.finto.fi and do...
Development

Successfully merging this pull request may close these issues.

None yet

2 participants