fix(required): correctly validate when required on non-input element …

…is surrounded by ngIf Closes angular#16830
Narretz · Feb 20, 2019 · 9be1198 · 9be1198
1 parent 005dd97
commit 9be1198
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/ng/directive/validators.js b/src/ng/directive/validators.js
@@ -68,15 +68,21 @@ var requiredDirective = ['$parse', function($parse) {
     require: '?ngModel',
     link: function(scope, elm, attr, ctrl) {
       if (!ctrl) return;
-      var value = attr.required || $parse(attr.ngRequired)(scope);
+      // For boolean attributes like required, presence means true
+      var value = 'required' in attr || $parse(attr.ngRequired)(scope);
 
-      attr.required = true; // force truthy in case we are on non input element
+      if (!attr.ngRequired) {
+        // force truthy in case we are on non input element
+        // (input elements do this automatically for boolean attributes like required)
+        attr.required = true;
+      }
 
       ctrl.$validators.required = function(modelValue, viewValue) {
         return !value || !ctrl.$isEmpty(viewValue);
       };
 
       attr.$observe('required', function(newVal) {
+
         if (value !== newVal) {
           value = newVal;
           ctrl.$validate();

diff --git a/test/ng/directive/validatorsSpec.js b/test/ng/directive/validatorsSpec.js
@@ -731,6 +731,7 @@ describe('validators', function() {
       expect(helper.validationCounter.required).toBe(1);
     });
 
+
     it('should validate once when inside ngRepeat, and set the "required" error when ngRequired is false by default', function() {
       $rootScope.isRequired = false;
       $rootScope.refs = {};
@@ -744,5 +745,15 @@ describe('validators', function() {
       expect($rootScope.refs.input.$error.required).toBeUndefined();
     });
 
+
+    it('should validate only once when inside ngIf with required on non-input elements', inject(function($compile) {
+      $rootScope.value = '12';
+      $rootScope.refs = {};
+      helper.compileInput('<div ng-if="true"><span ng-model="value" ng-ref="refs.ctrl" ng-ref-read="ngModel" required validation-spy="required"></span></div>');
+      $rootScope.$digest();
+
+      expect(helper.validationCounter.required).toBe(1);
+      expect($rootScope.refs.ctrl.$error.required).not.toBe(true);
+    }));
   });
 });