Skip to content

Commit

Permalink
Merge branch 'nyup-799_open-square-search-upgrade-webdriverio-from-5-…
Browse files Browse the repository at this point in the history
…x-to-7-x' into develop
  • Loading branch information
da70 committed Jun 10, 2021
2 parents 1098c25 + 6625115 commit a16a195
Show file tree
Hide file tree
Showing 3 changed files with 1,122 additions and 520 deletions.
18 changes: 9 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@
"@vue/cli-service": "^3.8.3",
"@vue/eslint-config-standard": "^4.0.0",
"@vue/test-utils": "^1.0.0-beta.29",
"@wdio/cli": "^5.10.4",
"@wdio/local-runner": "^5.10.4",
"@wdio/mocha-framework": "^5.10.1",
"@wdio/selenium-standalone-service": "^5.9.3",
"@wdio/spec-reporter": "^5.9.3",
"@wdio/sync": "^5.10.1",
"@wdio/cli": "^7.7.3",
"@wdio/local-runner": "^7.7.3",
"@wdio/mocha-framework": "^7.7.3",
"@wdio/selenium-standalone-service": "^7.7.3",
"@wdio/spec-reporter": "^7.7.3",
"@wdio/sync": "^7.7.3",
"babel-core": "7.0.0-bridge.0",
"babel-eslint": "^10.0.1",
"babel-jest": "^24.8.0",
Expand All @@ -71,11 +71,11 @@
"sass-loader": "^7.0.1",
"vue-jest": "^3.0.4",
"vue-template-compiler": "^2.6.10",
"webdriverio": "^5.10.4"
"webdriverio": "^7.7.3"
},
"engines": {
"node": ">= 6.0.0",
"npm": ">= 3.0.0"
"node": ">= 14.0.0",
"npm": ">= 7.0.0"
},
"jest": {
"moduleFileExtensions": [
Expand Down
24 changes: 22 additions & 2 deletions tests/browser/conf/wdio.main.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,20 @@ exports.config = {
// and 30 processes will get spawned. The property handles how many capabilities
// from the same test should run tests.
//
maxInstances : 6,
// NOTE: The above description of maxInstances from WebdriverIO does not appear to be correct.
// maxInstances seems to determine how many total browser instances can be open at once.
// If there are for example 9 test files and 2 capabilities (Firefox and Chrome, say) and
// maxInstances is set to 9, webdriverio will open 5 Chrome windows and 4 Firefox windows.
//
// See this ticket:
//
// "Open Square search: Firefox browser tests failing in prod with connection failure errors"
// https://jira.nyu.edu/jira/browse/NYUP-682
//
// ...for reason why Firefox must be limited to a single instance. We therefore
// set global maxInstances to 7 to allow for 6 Chrome instances, one for each
// test suite, and one single Firefox instance.
maxInstances : 7,
//
// If you have trouble getting all important capabilities together, check out the
// Sauce Labs platform configurator - a great tool to configure your capabilities:
Expand Down Expand Up @@ -98,7 +111,14 @@ exports.config = {
// maxInstances can get overwritten per capability. So if you have an in-house Selenium
// grid with only 5 firefox instances available you can make sure that not more than
// 5 instances get started at a time.
// maxInstances : 5,

// See this ticket:
//
// "Open Square search: Firefox browser tests failing in prod with connection failure errors"
// https://jira.nyu.edu/jira/browse/NYUP-682
//
// ...for reason why Firefox must be limited to a single instance.
maxInstances : 1,
//
browserName : 'firefox',
'moz:firefoxOptions' : {
Expand Down

0 comments on commit a16a195

Please sign in to comment.