Moved migration script in from core. #1071
Conversation
|
Not sure what's going on here but it's something about the Travis environment, not anything to do with this code. Here's a branch that doesn't change anything and its integration tests fail the same way: #1072 |
|
A new version of urllib3 was just released and I think one of its changes, probably urllib3/urllib3#1409, caused this problem. I don't know whether this needs to be fixed in urllib3, requests, or if we need to do something, but for now, refusing to use the new release seems to fix the problem. |
requirements.txt
Outdated
| @@ -5,6 +5,7 @@ elasticsearch-dsl<2.0.0 | |||
| pillow | |||
| psycopg2 | |||
| requests==2.18.4 | |||
| urllib3!=1.24 | |||
There was a problem hiding this comment.
I'd do < 1.24 since there may be more releases with the same problem.
| medium = cls.rbdigital_medium_to_simplified_medium.get( | ||
| rbdigital_medium, Edition.BOOK_MEDIUM | ||
| ) | ||
|
|
There was a problem hiding this comment.
I moved this code out of the if include_bibliographic block so it would always run and we would never have a situation where it was unclear what medium a title was. The medium is bibliographic information, but the RBdigital code also uses it to determine format information.
We could probably get rid of the include_bibliographic thing altogether, but there's no rush.
There was a problem hiding this comment.
I checked the other license sources and didn't find any other cases where we relied on the default Metadata.medium behavior that was removed from core.
Circulation portion of NYPL-Simplified/server_core#974. Updated submodule and moved in a migration script. The only change I made to the migration script was changing the code that modifies sys.path so that 'from core.model import' referred to the right place.