Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix some integer overflows #215

Merged
merged 1 commit into from Nov 5, 2020
Merged

Fix some integer overflows #215

merged 1 commit into from Nov 5, 2020

Conversation

RAMitchell
Copy link
Contributor

@RAMitchell RAMitchell commented Oct 15, 2020 •
edited

A few remaining ints changed to OffsetT. This allows us to switch cub to use 64 bit offsets via cub::DispatchScan without crashing.

Related: dmlc/xgboost#6234

@alliepiper
Copy link
Collaborator

Nice, thanks for tracking those down. I have one of these fixes in #210, but we definitely still need the others. You may be interested in some of the other DeviceScan fixes from that PR, too.

@alliepiper alliepiper added this to Inbox in PR Tracking via automation Oct 16, 2020
@alliepiper alliepiper added this to the 1.11.0 milestone Oct 16, 2020
@alliepiper
Copy link
Collaborator

Also be aware of #212. At some point I'd like to fix this in DeviceScan directly so you won't have to jump through hoops to deal with the Dispatch layer.

@alliepiper alliepiper moved this from Inbox to Needs Testing [PRs] in PR Tracking Oct 16, 2020
@alliepiper alliepiper added the testing: gpuCI passed Passed gpuCI testing. label Oct 18, 2020
@RAMitchell
Copy link
Contributor Author

Any updates on getting this or #210 merged? We are still blocked on this in xgboost.

@alliepiper
Copy link
Collaborator

Our internal CI/integration workflow is currently broken due to issues beyond our control. Hoping it's resolved by next week.

Once we have access to our CI again I'll run this (and the other ~15 Thrust/CUB PRs currently blocked on CI) through testing ASAP and hopefully land them in time for the 1.11.0 release scheduled for 2020-11-15.

@alliepiper
Copy link
Collaborator

DVS CL: 29265311

@alliepiper alliepiper added the testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). label Oct 30, 2020
@alliepiper alliepiper moved this from Needs Testing [PRs] to Tests Pending [PRs] in PR Tracking Oct 30, 2020
@alliepiper alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Nov 3, 2020
@alliepiper alliepiper moved this from Tests Pending [PRs] to Integration [PRs] in PR Tracking Nov 3, 2020
@alliepiper alliepiper merged commit 2ed4781 into NVIDIA:main Nov 5, 2020
PR Tracking automation moved this from Integration [PRs] to Done Nov 5, 2020
@alliepiper alliepiper mentioned this pull request Nov 5, 2020
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

Assignees
No one assigned
Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
PR Tracking
Done
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RAMitchell @alliepiper