LogFactory - Avoid checking candidate NLog-config files for every Logger created #4824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NLog should not introduce a performance-hit during application-startup when not able to load
NLog.config
(Or no NLog.config available). The performance-hit would depend on the number of unique Logger-objects that are created.Before it would attempt to scan all NLog-config-candidate-file-locations for every unique Logger-object created by the application (until NLog-config has been loaded). Now it will only do an initial auto-scan on the first Logger-creation.
One could consider creating a fluent
Setup()
-extension-method that starts file-watchers for all candidate-locations, that stays active until a valid NLog-configuration is loaded. See also #1114