Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLogConfigurationException constructor with string.Format marked obsolete #4807

Merged
merged 1 commit into from
Feb 26, 2022
Merged

NLogConfigurationException constructor with string.Format marked obsolete #4807

merged 1 commit into from
Feb 26, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 25, 2022 •
edited

Avoid pitfall when using string.Format without any parameters, and the input-string is not a valid string-format-template.

Now NLogConfigurationException matches ArgumentException-constructors.

See also #4805

@snakefoot snakefoot added this to the 5.0 (new) milestone Feb 25, 2022
304NotModified
304NotModified approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@snakefoot snakefoot closed this Feb 26, 2022
@snakefoot snakefoot reopened this Feb 26, 2022
@snakefoot snakefoot closed this Feb 26, 2022
@snakefoot snakefoot reopened this Feb 26, 2022
@snakefoot snakefoot enabled auto-merge (squash) February 26, 2022 10:32
@snakefoot snakefoot closed this Feb 26, 2022
auto-merge was automatically disabled February 26, 2022 11:19

Pull request was closed

@snakefoot snakefoot reopened this Feb 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

58.3% 58.3% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit 9440bca into NLog:dev Feb 26, 2022
@snakefoot snakefoot mentioned this pull request Feb 26, 2022
Merged
@snakefoot
Copy link
Contributor Author

NLogRuntimeException also has this string.Format-logic. So created #4808

@snakefoot snakefoot added the breaking change Breaking API change (different to semantic change) label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
breaking change Breaking API change (different to semantic change) refactoring size/M
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snakefoot @304NotModified