Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LineEndingMode - Support TypeConverter on NETSTANDARD1_3 #4552

Merged
merged 1 commit into from
Sep 6, 2021
Merged

LineEndingMode - Support TypeConverter on NETSTANDARD1_3 #4552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/NLog/Targets/LineEndingMode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ namespace NLog.Targets
/// <summary>
/// Line ending mode.
/// </summary>
#if !NETSTANDARD1_3
[TypeConverter(typeof(LineEndingModeConverter))]
#endif
public sealed class LineEndingMode : IEquatable<LineEndingMode>
{
/// <summary>
Expand Down Expand Up @@ -225,7 +223,6 @@ public bool Equals(LineEndingMode other)
return ReferenceEquals(this, other) || string.Equals(_newLineCharacters, other?._newLineCharacters);
}

#if !NETSTANDARD1_3
/// <summary>
/// Provides a type converter to convert <see cref="LineEndingMode"/> objects to and from other representations.
/// </summary>
Expand Down Expand Up @@ -260,6 +257,5 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
return name != null ? FromString(name) : base.ConvertFrom(context, culture, value);
}
}
#endif
}
}