AppSettingLayoutRenderer2 - Added support for ConnectionStrings Lookup #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@304NotModified Possible candidate for NLog 4.6.5 ? (Notice I have rebased to master) |
snakefoot
force-pushed
the
AppSettingThreadSafe
branch
from
0c2607e
to
7209cf0
Compare
|
4.6.5 sounds good! |
snakefoot
force-pushed
the
AppSettingThreadSafe
branch
from
7a7f54f
to
cf54a14
Compare
|
Remember 4.6.5-milestone. Will update the Wiki |
|
Thanks! |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convinced https://github.com/markmcdowell/NLog.Targets.ElasticSearch to remove their support for ConnectionStringName-Lookup because there is
${configsetting:item=ConnectionStrings.ElasticUrl}.But now there is no help for NetFramework app.config. This allows one to use:
${appsetting:item=ConnectionStrings.ElasticUrl}.