FilteringTargetWrapper - Fix XSD for Filter-property #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3476 +/- ##
======================================
+ Coverage 81% 81% +<1%
======================================
Files 343 343
Lines 27834 27834
Branches 3766 3766
======================================
+ Hits 22447 22469 +22
+ Misses 4295 4282 -13
+ Partials 1092 1083 -9 |
304NotModified
approved these changes
Jun 13, 2019
|
Oops wrong branch |
|
Will cherry pick |
304NotModified
pushed a commit
that referenced
this pull request
Jun 13, 2019
* FilteringTargetWrapper - Fix XSD for Filter-property * FilteringTargetWrapper - Fix XSD for Filter-property (never as attribute) * FilteringTargetWrapper - Updated unit-test to fail when adding unwanted attribute * Added tests
|
note: follow up here: #3486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More improvements to #3474, and no use of NLogConfigurationIgnoreProperty
resolves #3472