Added null terminator line ending mode #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## master #3453 +/- ##
=======================================
+ Coverage 80% 80% +<1%
=======================================
Files 359 359
Lines 28634 28636 +2
Branches 3817 3818 +1
=======================================
+ Hits 22916 22919 +3
Misses 4620 4620
+ Partials 1098 1097 -1 |
|
THanks for the PR! What's the exact use case for this line ending? |
|
Graylog GELF over TCP has option for null terminator line ending mode. It's called null frame delimiter. |
|
thanks! I changed to commit to master, so I could include it in NLog 4.6.5 :) |
|
Nice. Thanks :) |
|
Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks! |
304NotModified
pushed a commit
that referenced
this pull request
Jun 11, 2019
|
NLog 4.6.5 has been released! https://www.nuget.org/packages/NLog/4.6.5 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are only 4 options for target line ending mode, CRLF|LF|CR|None.
This pull request adds null terminator line ending mode to target "lineEnding" attribute in configuration.
https://github.com/NLog/NLog/wiki/Network-target