RetryingMultiProcessFileAppender - better init BufferSize #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3444 +/- ##
=====================================
Coverage ? 81%
=====================================
Files ? 341
Lines ? 27786
Branches ? 3758
=====================================
Hits ? 22432
Misses ? 4271
Partials ? 1083 |
304NotModified
force-pushed
the
RetryingFileAppenderBufferSize
branch
from
f008631
to
430a64f
Compare
|
rebased on master :) |
304NotModified
approved these changes
May 30, 2019
304NotModified
changed the title
|
thanks! |
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferSize should match byte-count
No need to allocate 30.000 bytes to write 100 bytes.