Log4JXmlEventLayout - Added IncludeCallSite + IncludeSourceInfo #3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. |
I think that's better indeed. NLog 5 take some weeks at least |
Codecov Report
@@ Coverage Diff @@
## release/4.6.5 #3442 +/- ##
==============================================
+ Coverage 80% 80% +<1%
==============================================
Files 359 359
Lines 28634 28638 +4
Branches 3817 3817
==============================================
+ Hits 22916 22931 +15
+ Misses 4620 4604 -16
- Partials 1098 1103 +5 |
snakefoot
force-pushed
the
Log4JXmlEventLayoutCallSite
branch
from
a1f75a8
to
4ed3aeb
Compare
snakefoot
force-pushed
the
Log4JXmlEventLayoutCallSite
branch
from
4ed3aeb
to
334e572
Compare
Rebased to master |
304NotModified
approved these changes
May 30, 2019
|
@snakefoot could you please help me with the docs? Working on a release now |
|
Have updated the wiki: https://github.com/NLog/NLog/wiki/Log4JXmlEventLayout |
|
thanks! |
304NotModified
added
the
documentation done
304NotModified
pushed a commit
that referenced
this pull request
Jun 11, 2019
|
FYI, delaying 4.6.5 for #3472 😞 |
|
@SkinnySackboy NLog 4.6.5 has been released! https://www.nuget.org/packages/NLog/4.6.5 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing a nail to resolve #3387
One could probably rebase to NLog:master