Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectReflectionCache - Skip property-reflection for IFormattable #3434

Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented May 25, 2019

Avoid serializing JSON.NET JValue-properties when it contains a non-primitive object (Ex. like TimeSpan).

@codecov-io
Copy link

Codecov Report

Merging #3434 into release/4.6.4 will decrease coverage by <1%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           release/4.6.4   #3434    +/-   ##
==============================================
- Coverage             80%     80%   -<1%     
==============================================
  Files                358     358            
  Lines              28516   28514     -2     
  Branches            3814    3813     -1     
==============================================
- Hits               22846   22825    -21     
- Misses              4569    4589    +20     
+ Partials            1101    1100     -1

@304NotModified 304NotModified added the enhancement Improvement on existing feature label May 26, 2019
@304NotModified 304NotModified added this to the 4.6.4 milestone May 26, 2019
@304NotModified
Copy link
Member

Thanks!

@304NotModified 304NotModified merged commit b83d37f into NLog:release/4.6.4 May 26, 2019
@snakefoot snakefoot deleted the TypeConvertUsingInterface branch April 4, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants