Added "Properties" property on Logger for reading and editing properties. #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
DictionaryCopyOnWrite
branch
2 times, most recently
from
5e206dc
to
ee33f0e
Compare
snakefoot
force-pushed
the
DictionaryCopyOnWrite
branch
from
ee33f0e
to
ee168fb
Compare
Codecov Report
@@ Coverage Diff @@
## release/4.6.4 #3430 +/- ##
==============================================
- Coverage 80% 80% -<1%
==============================================
Files 358 359 +1
Lines 28514 28634 +120
Branches 3813 3817 +4
==============================================
+ Hits 22825 22913 +88
- Misses 4589 4621 +32
Partials 1100 1100 |
304NotModified
approved these changes
May 25, 2019
Should say:
|
304NotModified
changed the title
304NotModified
force-pushed
the
DictionaryCopyOnWrite
branch
from
7489261
to
c13849c
Compare
|
@304NotModified Guess this is the last bullet before NLog 4.6.5? Think it would be great to have #3414 resolved :) |
Yes indeed :) (I assume you mean 4.6.4) |
|
Yes you are right. Been seeing 4.6.4 so long time that I have started thinking it as released :)
|
|
Remember to add this PR to the 4.6.4 milestone-version.
|
304NotModified
pushed a commit
that referenced
this pull request
May 28, 2019
…ies. (#3430) * Logger - Properties added using WithProperty can now be inspected safely * small code improvement
|
thanks, it's anyway in the changelog. offtopic: What is |
When I reply to Github-issues from the Email-program on my phone, then strange things happens. |
|
LOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger - Properties added using WithProperty can now be inspected safely
Alternative implementation of #3424 to fix #3422
Also resolves partly #2960 (Still doesn't resolve use of SimpleLayout that are not threadsafe). And there will now be a performance-hit if very aggressive about modifying NLog-variables, and have many of them.