AsyncWrapper in Blocking Mode can cause deadlock on NetCore #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitor.Wait with timeout
|
Will have to figure out if we can reuse one of the existing unit-tests for stress-testing the async-queue to verify the bug is gone. |
Codecov Report
@@ Coverage Diff @@
## release/4.6.4 #3415 +/- ##
===============================================
Coverage ? 80%
===============================================
Files ? 358
Lines ? 28371
Branches ? 3785
===============================================
Hits ? 22753
Misses ? 4531
Partials ? 1087 |
304NotModified
approved these changes
May 22, 2019
304NotModified
changed the title
snakefoot
changed the title
|
Created #3416 with unit-test. And also discovered a performance opportunity. |
snakefoot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed deadlock caused by misunderstanding Monitor.Wait when configuring AsyncWrapper to Blocking-mode on NetCore.
Resolves #3414