${whenEmpty} implemented IRawValue and IStringValueRenderer #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/4.6.4 #3398 +/- ##
==============================================
+ Coverage 80% 80% +<1%
==============================================
Files 357 357
Lines 28262 28302 +40
Branches 3760 3767 +7
==============================================
+ Hits 22636 22671 +35
- Misses 4531 4537 +6
+ Partials 1095 1094 -1 |
304NotModified
approved these changes
May 14, 2019
| /// <inheritdoc/> | ||
| protected override void InitializeLayoutRenderer() | ||
| { | ||
| base.InitializeLayoutRenderer(); | ||
| WhenEmpty?.Initialize(LoggingConfiguration); | ||
| _skipStringValueRenderer = !TryGetStringValue(out var _, out var _); |
There was a problem hiding this comment.
I think you don't want var here ;) (the _ is also a keyword)
I have updated it
|
Thanks! Refactored some duplicate lines and added some tests. Now good to go :) |
304NotModified
changed the title
304NotModified
changed the title
304NotModified
changed the title
304NotModified
pushed a commit
that referenced
this pull request
May 20, 2019
* WhenEmptyLayoutRendererWrapper with IRawValue and IStringValueRenderer * refactor * added test
304NotModified
pushed a commit
that referenced
this pull request
May 28, 2019
* WhenEmptyLayoutRendererWrapper with IRawValue and IStringValueRenderer * refactor * added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation of #3395