Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package descriptions to note the issues with <PackageReference> #3393

Merged
merged 1 commit into from May 13, 2019

Conversation

304NotModified
Copy link
Member

fixes #3390

@304NotModified 304NotModified added this to the 4.6.4 milestone May 12, 2019
@304NotModified 304NotModified changed the base branch from dev to release/4.6.4 May 12, 2019 21:08
@304NotModified 304NotModified changed the title Update package descriptions Update package descriptions to note the issues with <PackageReference> May 12, 2019
@codecov-io
Copy link

Codecov Report

Merging #3393 into release/4.6.4 will decrease coverage by <1%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release/4.6.4   #3393    +/-   ##
==============================================
- Coverage             80%     80%   -<1%     
==============================================
  Files                357     357            
  Lines              28247   28297    +50     
  Branches            3758    3766     +8     
==============================================
+ Hits               22616   22642    +26     
- Misses              4541    4550     +9     
- Partials            1090    1105    +15

@304NotModified 304NotModified merged commit 3b38fdc into release/4.6.4 May 13, 2019
@repo-ranger repo-ranger bot deleted the update-packages-texts branch May 13, 2019 22:07
@snakefoot
Copy link
Contributor

@304NotModified
Copy link
Member Author

Good point, but IMO the tutorial is on too high level and also references the nlog config package...

@snakefoot
Copy link
Contributor

snakefoot commented May 15, 2019

Maybe the tutorial should not give high recommendation for using NLog.config, but just mention that it exists (and that NLog.config-package only works sometimes, and other times can be a world of hurt).

People deciding whether to use the NLog.config-package are most likely looking for a high-level-introduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants