Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ${environment-user} #3391

Merged
merged 1 commit into from May 12, 2019
Merged

Added ${environment-user} #3391

merged 1 commit into from May 12, 2019

Conversation

snakefoot
Copy link
Contributor

Resolves #3381

@snakefoot snakefoot force-pushed the EnvironmentUserLayoutRenderer branch 3 times, most recently from 83430b9 to a3d3b26 Compare May 12, 2019 12:07
@codecov-io
Copy link

codecov-io commented May 12, 2019 •
edited

Codecov Report

Merging #3391 into master will increase coverage by <1%.
The diff coverage is 69%.

@@           Coverage Diff           @@
##           master   #3391    +/-   ##
=======================================
+ Coverage      80%     80%   +<1%     
=======================================
  Files         356     355     -1     
  Lines       28205   28141    -64     
  Branches     3750    3744     -6     
=======================================
- Hits        22559   22545    -14     
+ Misses       4540    4511    -29     
+ Partials     1106    1085    -21

@304NotModified
Copy link
Member

This could be also on 4.6.4? Small chance on conflicts :)

@snakefoot snakefoot force-pushed the EnvironmentUserLayoutRenderer branch from a3d3b26 to 445e5bc Compare May 12, 2019 19:06
@snakefoot snakefoot changed the base branch from dev to master May 12, 2019 19:07
@snakefoot
Copy link
Contributor Author

@304NotModified Changed base to master

@304NotModified 304NotModified changed the title EnvironmentUserLayoutRenderer - UserName on NetCore Added ${environment-user} May 12, 2019
@304NotModified 304NotModified added this to the 4.6.4 milestone May 12, 2019
@304NotModified 304NotModified changed the base branch from master to release/4.6.4 May 12, 2019 20:39
@304NotModified 304NotModified merged commit 0c84b12 into NLog:release/4.6.4 May 12, 2019
@304NotModified
Copy link
Member

Could you please help me with the docs? Thanks!

@snakefoot
Copy link
Contributor Author

Could you please help me with the docs? Thanks!

Created https://github.com/NLog/NLog/wiki/Environment-User-Layout-Renderer and made a link from https://github.com/NLog/NLog/wiki/Windows-Identity-Layout-Renderer

@304NotModified 304NotModified mentioned this pull request May 20, 2019
Merged
@304NotModified
Copy link
Member

thanks. I've added NLog/NLog.github.io#116

@304NotModified 304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label May 20, 2019
@snakefoot snakefoot deleted the EnvironmentUserLayoutRenderer branch April 4, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) feature needs documentation on wiki needs documention on nlog-project.org/config
Projects
None yet
Milestone
4.6.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snakefoot @codecov-io @304NotModified