Log4JXmlEventLayout - Added support for configuration of Parameters #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3389 +/- ##
=======================================
+ Coverage 80% 80% +<1%
=======================================
Files 356 356
Lines 28205 28212 +7
Branches 3750 3753 +3
=======================================
+ Hits 22559 22607 +48
+ Misses 4540 4512 -28
+ Partials 1106 1093 -13 |
snakefoot
force-pushed
the
Log4JXmlEventLayoutParameters
branch
from
af0ace9
to
c05cd95
Compare
|
@304NotModified Can also be included for NLog 4.6.4 |
|
Ok! Could you please rebase it on master and change the PR's base afterwards? Thanks! |
snakefoot
force-pushed
the
Log4JXmlEventLayoutParameters
branch
from
c05cd95
to
36e7ee8
Compare
snakefoot
force-pushed
the
Log4JXmlEventLayoutParameters
branch
from
36e7ee8
to
f6c7f86
Compare
|
@304NotModified Changed base to master |
|
great work! thanks! I will merge it first to an intermediate release branch (so I won't break the debug symbols of 4.6.3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.