ShortDateLayoutRenderer with support for IRawValue + IStringValueRenderer #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
ShortDateStringRender
branch
from
3e95b3f
to
e66ffba
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3337 +/- ##
======================================
- Coverage 80% 80% -<1%
======================================
Files 356 356
Lines 28213 28226 +13
Branches 3763 3763
======================================
+ Hits 22572 22579 +7
- Misses 4555 4558 +3
- Partials 1086 1089 +3 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to get current date as raw-value (Without time-part)
Makes it possible to use
${ShortDate}incacheKeyfor https://github.com/NLog/NLog/wiki/Cached-Layout-Renderer with reduced string-allocations.