Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${event-properties} - Added ObjectPath for extracting nested object property #3329

Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Apr 22, 2019

Alternative implementation of #3318

${event-properties:myOrder:objectpath=OrderId}

Right now without fallback to case-insensitive lookup if the direct lookup fails.

@snakefoot snakefoot force-pushed the ObjectEventPropertyLayoutRenderer branch 2 times, most recently from bb6d2ef to c52ac48 Compare April 22, 2019 22:36
@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #3329 into dev will increase coverage by <1%.
The diff coverage is 83%.

@@          Coverage Diff           @@
##             dev   #3329    +/-   ##
======================================
+ Coverage     80%     80%   +<1%     
======================================
  Files        356     356            
  Lines      28101   28170    +69     
  Branches    3743    3756    +13     
======================================
+ Hits       22517   22585    +68     
+ Misses      4503    4499     -4     
- Partials    1081    1086     +5

@snakefoot snakefoot force-pushed the ObjectEventPropertyLayoutRenderer branch 3 times, most recently from 2b049d6 to 8580b96 Compare April 23, 2019 16:37
@snakefoot snakefoot changed the title ObjectEventPropertyLayoutRenderer - Extract nested object property ${event-properties} - Added ObjectPath for extracting nested object property Apr 23, 2019
@snakefoot snakefoot force-pushed the ObjectEventPropertyLayoutRenderer branch from 8580b96 to 036ebf3 Compare April 23, 2019 18:06
@304NotModified
Copy link
Member

I think this is also better to have in ${event-properties} :)

@304NotModified 304NotModified merged commit 39e7293 into NLog:dev Apr 26, 2019
@304NotModified
Copy link
Member

cool! Merged!

@304NotModified
Copy link
Member

docs -> https://github.com/NLog/NLog/wiki/EventProperties-Layout-Renderer

@304NotModified 304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Apr 29, 2019
@snakefoot snakefoot deleted the ObjectEventPropertyLayoutRenderer branch April 4, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) feature needs documentation on wiki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants