Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FallbackGroupTarget - Fixed spelling of WINDOWS_PHONE define + improvement GarbageCollection2Test() unit test on Travis #3320

Merged
merged 2 commits into from Apr 21, 2019
Merged

FallbackGroupTarget - Fixed spelling of WINDOWS_PHONE define + improvement GarbageCollection2Test() unit test on Travis #3320

merged 2 commits into from Apr 21, 2019

Conversation

snakefoot
Copy link
Contributor

No description provided.

@snakefoot snakefoot mentioned this pull request Apr 20, 2019
Merged
@304NotModified
Copy link
Member

Thanks!

@304NotModified 304NotModified added this to the 4.6.3 milestone Apr 20, 2019
@304NotModified 304NotModified added bug Bug report / Bug fix merge when passing labels Apr 20, 2019
@snakefoot snakefoot force-pushed the FallbackGroupTargetWindowsPhone branch from 5dd5ba5 to 99e5e1c Compare April 20, 2019 19:20
@codecov-io
Copy link

codecov-io commented Apr 20, 2019 •
edited

Codecov Report

Merging #3320 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##             dev   #3320    +/-   ##
======================================
+ Coverage     80%     80%   +<1%     
======================================
  Files        356     356            
  Lines      28100   28100            
  Branches    3743    3743            
======================================
+ Hits       22510   22528    +18     
+ Misses      4509    4490    -19     
- Partials    1081    1082     +1

@snakefoot snakefoot force-pushed the FallbackGroupTargetWindowsPhone branch from 4994f2d to 99e5e1c Compare April 20, 2019 19:37
@304NotModified
Copy link
Member

Travis seems to be broken

0.50sE: Unable to locate package dotnet-sdk-2.0.0
E: Couldn't find any package by glob 'dotnet-sdk-2.0.0'
E: Couldn't find any package by regex 'dotnet-sdk-2.0.0'
The command "sudo apt-get install -qq dotnet-sdk-2.0.0" failed and exited with 100 during .

@304NotModified
Copy link
Member

Fix?
https://www.queryxchange.com/q/27_55757025/travis-e-unable-to-locate-package-dotnet-sdk-2-0-0/

@snakefoot
Copy link
Contributor Author

Trusty is Ubuntu 14.04
Xenial is Ubuntu 16.04

Major version is the release year. Guess there is nothing wrong with upgrading Travis to year 2016.

@304NotModified
Copy link
Member

Indeed! #3325

@snakefoot snakefoot force-pushed the FallbackGroupTargetWindowsPhone branch from 99e5e1c to 453cf48 Compare April 21, 2019 20:38
@304NotModified 304NotModified changed the title FallbackGroupTarget - Fixed spelling of WINDOWS_PHONE define FallbackGroupTarget - Fixed spelling of WINDOWS_PHONE define + improvement unit tests on Travis Apr 21, 2019
@304NotModified 304NotModified changed the title FallbackGroupTarget - Fixed spelling of WINDOWS_PHONE define + improvement unit tests on Travis FallbackGroupTarget - Fixed spelling of WINDOWS_PHONE define + improvement GarbageCollection2Test() unit test on Travis Apr 21, 2019
@snakefoot snakefoot force-pushed the FallbackGroupTargetWindowsPhone branch from 65ef9c5 to dcf9181 Compare April 21, 2019 20:55
@repo-ranger repo-ranger bot merged commit 34d23d5 into NLog:dev Apr 21, 2019
@snakefoot snakefoot deleted the FallbackGroupTargetWindowsPhone branch April 4, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
bug Bug report / Bug fix
Projects
None yet
Milestone
4.6.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snakefoot @304NotModified @codecov-io