NLog config - Fixed bug where empty xml-elements were ignored #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Value or attributes was ignored
|
great work! |
Would have been even greater if the bug was never made. Especially since I created it :) But we now have an unit-test to protect us from it happening again. |
304NotModified
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #3271 +/- ##
======================================
+ Coverage 80% 80% +<1%
======================================
Files 355 355
Lines 27986 27995 +9
Branches 3727 3728 +1
======================================
+ Hits 22324 22358 +34
+ Misses 4579 4554 -25
Partials 1083 1083 |
|
congrats @snakefoot
|
|
Yes why not make it "Champagne Tuesday" :). And thank you |
|
🍾 🎉 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggingConfigurationParser - Fixed bug where empty xml-node-elements was ignored
Resolves #3268