Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error with Embedded Assembly in LogAssemblyVersion #3258

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Fix error with Embedded Assembly in LogAssemblyVersion #3258

merged 1 commit into from
Mar 29, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 29, 2019 •
edited by 304NotModified

with Embedded Assembly.Location can be null or empty

@304NotModified Bonus PR before NLog 4.6.1 ?

See also https://stackoverflow.com/questions/55424751/how-to-resolve-error-when-using-nlog-with-costura-fody#55424751

#736 + #1500 suffers from the same problem with LogAssemblyVersion throwing The path is not of a legal form

304NotModified
304NotModified approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was also looking at the issue on stack overflow. I will include this in NLog 4.6.1

@304NotModified 304NotModified added this to the 4.6.1 milestone Mar 29, 2019
@304NotModified 304NotModified added the bug Bug report / Bug fix label Mar 29, 2019
@304NotModified 304NotModified changed the title LogAssemblyVersion - Embedded Assembly.Location can be null or empty LogAssemblyVersion - fix crash with Embedded Assembly.Location can be null or empty Mar 29, 2019
@304NotModified 304NotModified changed the title LogAssemblyVersion - fix crash with Embedded Assembly.Location can be null or empty Fix error with Embedded Assembly in LogAssemblyVersion Mar 29, 2019
@304NotModified 304NotModified merged commit fef122c into NLog:dev Mar 29, 2019
@snakefoot snakefoot mentioned this pull request Oct 4, 2019
Closed
@snakefoot snakefoot deleted the InternalLoggerAssemblyVersion branch April 4, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
bug Bug report / Bug fix
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snakefoot @304NotModified