Fix wrong warnings on <nlog> element + refactoring #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
LoggingConfigurationParserUnknownChild
branch
3 times, most recently
from
0acb5cd
to
0dca49d
Compare
|
While I like refactorings, this change is hard to review that no new bugs are introduced. But I you think this is better than #3254, I'm OK with taking this one. |
snakefoot
force-pushed
the
LoggingConfigurationParserUnknownChild
branch
from
0dca49d
to
2531fc5
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3253 +/- ##
======================================
+ Coverage 80% 80% +<1%
======================================
Files 354 355 +1
Lines 27927 28101 +174
Branches 3709 3768 +59
======================================
+ Hits 22265 22466 +201
+ Misses 4597 4552 -45
- Partials 1065 1083 +18 |
snakefoot
force-pushed
the
LoggingConfigurationParserUnknownChild
branch
from
2531fc5
to
c159008
Compare
snakefoot
force-pushed
the
LoggingConfigurationParserUnknownChild
branch
2 times, most recently
from
aea5d7c
to
a849dee
Compare
snakefoot
force-pushed
the
LoggingConfigurationParserUnknownChild
branch
from
a849dee
to
2f554da
Compare
304NotModified
changed the title
304NotModified
approved these changes
Mar 28, 2019
304NotModified
changed the title
304NotModified
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3251